[Synthetics] Add new object into read synthetics feature !! #201170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzad31
added
release_note:skip
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
kdelemme
approved these changes
Nov 21, 2024
justinkambic
approved these changes
Nov 21, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
azasypkin
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Changes in x-pack/test_serverless/api_integration/test_suites/observability/platform_security/authorization.ts LGTM!
This is a regression from the PR #195874, where we added the new type into all but didn't do it for read.
This makes me think you really need an integration test to validate that a user with a role granting only read access can access private location SO. However, I didn’t see one in this PR 🙂
|
Starting backport for target branches: 8.17, 8.x https://github.com/elastic/kibana/actions/runs/11958682847 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 21, 2024
…201170) ## Summary This is a regression from the PR elastic#195874, where we added the new type into all but didn't do it for read. (cherry picked from commit 5d4282e)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 21, 2024
…201170) ## Summary This is a regression from the PR elastic#195874, where we added the new type into all but didn't do it for read. (cherry picked from commit 5d4282e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 21, 2024
…201170) (#201258) # Backport This will backport the following commits from `main` to `8.17`: - [[Synthetics] Add new object into read synthetics feature !! (#201170)](#201170) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2024-11-21T17:40:09Z","message":"[Synthetics] Add new object into read synthetics feature !! (#201170)\n\n## Summary\n\nThis is a regression from the PR\nhttps://github.com//pull/195874, where we added the new\ntype into all but didn't do it for read.","sha":"5d4282e91621b433e2bdf7201f9bedf47661d152","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","backport:version","v8.17.0","v8.18.0"],"title":"[Synthetics] Add new object into read synthetics feature !!","number":201170,"url":"https://github.com/elastic/kibana/pull/201170","mergeCommit":{"message":"[Synthetics] Add new object into read synthetics feature !! (#201170)\n\n## Summary\n\nThis is a regression from the PR\nhttps://github.com//pull/195874, where we added the new\ntype into all but didn't do it for read.","sha":"5d4282e91621b433e2bdf7201f9bedf47661d152"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201170","number":201170,"mergeCommit":{"message":"[Synthetics] Add new object into read synthetics feature !! (#201170)\n\n## Summary\n\nThis is a regression from the PR\nhttps://github.com//pull/195874, where we added the new\ntype into all but didn't do it for read.","sha":"5d4282e91621b433e2bdf7201f9bedf47661d152"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Nov 21, 2024
…01170) (#201259) # Backport This will backport the following commits from `main` to `8.x`: - [[Synthetics] Add new object into read synthetics feature !! (#201170)](#201170) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2024-11-21T17:40:09Z","message":"[Synthetics] Add new object into read synthetics feature !! (#201170)\n\n## Summary\n\nThis is a regression from the PR\nhttps://github.com//pull/195874, where we added the new\ntype into all but didn't do it for read.","sha":"5d4282e91621b433e2bdf7201f9bedf47661d152","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","backport:version","v8.17.0","v8.18.0"],"title":"[Synthetics] Add new object into read synthetics feature !!","number":201170,"url":"https://github.com/elastic/kibana/pull/201170","mergeCommit":{"message":"[Synthetics] Add new object into read synthetics feature !! (#201170)\n\n## Summary\n\nThis is a regression from the PR\nhttps://github.com//pull/195874, where we added the new\ntype into all but didn't do it for read.","sha":"5d4282e91621b433e2bdf7201f9bedf47661d152"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201170","number":201170,"mergeCommit":{"message":"[Synthetics] Add new object into read synthetics feature !! (#201170)\n\n## Summary\n\nThis is a regression from the PR\nhttps://github.com//pull/195874, where we added the new\ntype into all but didn't do it for read.","sha":"5d4282e91621b433e2bdf7201f9bedf47661d152"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
…201170) ## Summary This is a regression from the PR elastic#195874, where we added the new type into all but didn't do it for read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a regression from the PR #195874, where we added the new type into all but didn't do it for read.